Improve admin candidate modal UX and add clip menu visibility toggle

- Widen AdminCandidateEditorModal to size lg for better readability - Rename "Clip-Compilation" section to "Clip / Compilation", update copy to reflect single clips too, drop upload hint and Clip-Plattform field, rename label to "Link" - Fix NativeSelect dropdown clipping inside overflow-y-auto modals by teleporting the menu to body with fixed positioning, flip-up logic, and dynamic maxHeight capped to viewport - Add ClipAdminMenuVisible setting (backend domain, contracts, endpoint, migration) with matching frontend types, defaults, form wiring, and toggle in the Clip-Workflow modal — hides the Clips nav item from the admin sidebar when disabled Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-27 18:39:35 +02:00
parent 494eba5edd
commit 18b61bed52
119 changed files with 15638 additions and 367 deletions
@@ -1,6 +1,8 @@
 using Backend.Common;
 using Backend.Contracts;
 using Backend.Data;
+using Backend.Domain;
+using Backend.Services;
 using Microsoft.EntityFrameworkCore;

 namespace Backend.Endpoints;
@@ -14,6 +16,17 @@ public static partial class AdminSeasonManagementEndpoints
    private const int MaxCandidateDisplayNameLength = 120;
    private const int MaxCandidateChannelSlugLength = 120;
    private const int MaxCandidatePlatformLength = 60;
+    private const int MaxCandidateAcceptanceNoteLength = 500;
+    private const int MaxCandidateClipUrlLength = 500;
+    private const int MaxCandidateClipTitleLength = 200;
+    private const int MaxCandidateClipPlatformLength = 40;
+
+    private sealed record CandidateRuleSnapshot(
+        int Id,
+        int CategoryId,
+        string DisplayName,
+        string ChannelSlug,
+        string AcceptanceStatus);

    private static IResult? ValidateSeasonRequest(CreateSeasonRequest request)
    {
@@ -132,6 +145,80 @@ public static partial class AdminSeasonManagementEndpoints
        });
    }

+    private static async Task<WorkflowRuleSetting[]> LoadWorkflowRulesAsync(AwardsDbContext db, CancellationToken cancellationToken)
+    {
+        var settings = await db.SiteSettings
+            .AsNoTracking()
+            .FirstOrDefaultAsync(item => item.Id == 1, cancellationToken);
+
+        return WorkflowRuleSettings.Read(settings);
+    }
+
+    private static IResult CreateWorkflowRuleError(string message) =>
+        Results.BadRequest(new { message = $"Workflow-Regel blockiert: {message}" });
+
+    private static async Task<IResult?> BuildCandidateWorkflowRuleBlockAsync(
+        AwardsDbContext db,
+        int seasonId,
+        int categoryId,
+        int? existingCandidateId,
+        string displayName,
+        string channelSlug,
+        string acceptanceStatus,
+        CancellationToken cancellationToken)
+    {
+        if (string.Equals(acceptanceStatus, "declined", StringComparison.OrdinalIgnoreCase))
+        {
+            return null;
+        }
+
+        var rules = await LoadWorkflowRulesAsync(db, cancellationToken);
+        var finalistsRule = WorkflowRuleSettings.Find(rules, WorkflowRuleSettings.MaxFinalistsPerCategory);
+        var appearancesRule = WorkflowRuleSettings.Find(rules, WorkflowRuleSettings.MaxCandidateAppearances);
+        if (!WorkflowRuleSettings.ShouldBlock(finalistsRule) && !WorkflowRuleSettings.ShouldBlock(appearancesRule))
+        {
+            return null;
+        }
+
+        var existingCandidates = await db.Candidates
+            .AsNoTracking()
+            .Where(item =>
+                item.SeasonId == seasonId
+                && (!existingCandidateId.HasValue || item.Id != existingCandidateId.Value)
+                && item.AcceptanceStatus != "declined")
+            .Select(item => new CandidateRuleSnapshot(
+                item.Id,
+                item.CategoryId,
+                item.DisplayName,
+                item.ChannelSlug,
+                item.AcceptanceStatus))
+            .ToArrayAsync(cancellationToken);
+
+        if (WorkflowRuleSettings.ShouldBlock(finalistsRule))
+        {
+            var categoryCount = existingCandidates.Count(item => item.CategoryId == categoryId);
+            if (categoryCount >= finalistsRule.Limit)
+            {
+                return CreateWorkflowRuleError(
+                    $"In dieser Kategorie sind bereits {categoryCount} von {finalistsRule.Limit} finalen Kandidat:innen angelegt.");
+            }
+        }
+
+        if (WorkflowRuleSettings.ShouldBlock(appearancesRule))
+        {
+            var identityKey = WorkflowRuleSettings.CandidateIdentityKey(displayName, channelSlug);
+            var appearanceCount = existingCandidates.Count(item =>
+                string.Equals(WorkflowRuleSettings.CandidateIdentityKey(item.DisplayName, item.ChannelSlug), identityKey, StringComparison.Ordinal));
+            if (appearanceCount >= appearancesRule.Limit)
+            {
+                return CreateWorkflowRuleError(
+                    $"Diese Person ist bereits {appearanceCount}x als Kandidat:in eingetragen. Limit: {appearancesRule.Limit}.");
+            }
+        }
+
+        return null;
+    }
+
    private static string[] BuildNewSeasonReadinessIssues(
        string currentPhase,
        bool isCurrent,
@@ -311,6 +398,51 @@ public static partial class AdminSeasonManagementEndpoints
            return Results.BadRequest(new { message = $"Platform is required and must stay below {MaxCandidatePlatformLength} characters." });
        }

+        if (!IsAllowedCandidateChoice(request.AcceptanceStatus, CandidateAcceptanceStatuses))
+        {
+            return Results.BadRequest(new { message = "Acceptance status must be open, contacted, accepted, or declined." });
+        }
+
+        if (!IsAllowedCandidateChoice(request.ClipEmbedStatus, CandidateClipEmbedStatuses))
+        {
+            return Results.BadRequest(new { message = "Clip embed status must be unchecked, embeddable, link_only, or blocked." });
+        }
+
+        if (request.AcceptanceNote?.Trim().Length > MaxCandidateAcceptanceNoteLength)
+        {
+            return Results.BadRequest(new { message = $"Acceptance note must stay below {MaxCandidateAcceptanceNoteLength} characters." });
+        }
+
+        var clipUrl = request.ClipCompilationUrl?.Trim();
+        if (!string.IsNullOrWhiteSpace(clipUrl))
+        {
+            if (clipUrl.Length > MaxCandidateClipUrlLength)
+            {
+                return Results.BadRequest(new { message = $"Compilation link must stay below {MaxCandidateClipUrlLength} characters." });
+            }
+
+            if (!Uri.TryCreate(clipUrl, UriKind.Absolute, out var uri) || uri.Scheme is not ("http" or "https"))
+            {
+                return Results.BadRequest(new { message = "Compilation link must be a valid http(s) URL." });
+            }
+        }
+
+        if (request.ClipCompilationTitle?.Trim().Length > MaxCandidateClipTitleLength)
+        {
+            return Results.BadRequest(new { message = $"Compilation title must stay below {MaxCandidateClipTitleLength} characters." });
+        }
+
+        if (request.ClipCompilationPlatform?.Trim().Length > MaxCandidateClipPlatformLength)
+        {
+            return Results.BadRequest(new { message = $"Compilation platform must stay below {MaxCandidateClipPlatformLength} characters." });
+        }
+
        return null;
    }
+
+    private static bool IsAllowedCandidateChoice(string? value, IReadOnlyCollection<string> allowedValues)
+    {
+        var normalized = value?.Trim();
+        return string.IsNullOrWhiteSpace(normalized) || allowedValues.Contains(normalized, StringComparer.OrdinalIgnoreCase);
+    }
 }