feat: ship agent-first mission control v0.2.57

backend-tests/MissionControlPhaseTests.cs

@@ -1,12 +1,10 @@
 using System.Reflection;
 using System.Security.Claims;
-using System.Text;
 using System.Text.Json;
 using Microsoft.AspNetCore.Http;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
-using Microsoft.Extensions.Configuration;
 using Nexus.Api.Data;
 using Nexus.Api.Controllers;
 using Nexus.Api.DTOs;
@@ -158,191 +156,10 @@ public sealed class MissionControlPhaseTests
         Assert.False(programmerEvents[0].Message.Contains("reviewer", StringComparison.OrdinalIgnoreCase));
     }
 
-    [Fact]
-    public async Task GatewayInfo_ReportsVersionDrift()
-    {
-        var client = CreateClient(_ => new HttpResponseMessage(System.Net.HttpStatusCode.OK)
-        {
-            Content = new StringContent("""{"version":"2026.07.08"}""", Encoding.UTF8, "application/json")
-        }, requiredVersion: "2026.07.09");
-
-        var info = await client.GetGatewayInfoAsync();
-
-        Assert.True(info.Reachable);
-        Assert.Equal("2026.07.08", info.Version);
-        Assert.Equal("2026.07.09", info.RequiredVersion);
-        Assert.Equal("drift", info.VersionStatus);
-        Assert.False(info.VersionMatches);
-        Assert.NotNull(info.Warning);
-        Assert.Contains("2026.07.08", info.Warning!);
-    }
-
-    [Fact]
-    public async Task GatewayInfo_ReportsMissingVersionWhenPinned()
-    {
-        var client = CreateClient(_ => new HttpResponseMessage(System.Net.HttpStatusCode.OK)
-        {
-            Content = new StringContent("""{"status":"ok"}""", Encoding.UTF8, "application/json")
-        }, requiredVersion: "2026.07.09");
-
-        var info = await client.GetGatewayInfoAsync();
-
-        Assert.True(info.Reachable);
-        Assert.Null(info.Version);
-        Assert.Equal("missing", info.VersionStatus);
-        Assert.False(info.VersionMatches);
-        Assert.NotNull(info.Warning);
-        Assert.Contains("2026.07.09", info.Warning!);
-    }
-
-    [Fact]
-    public async Task GatewayInfo_ReportsMatchedPinnedVersion()
-    {
-        var client = CreateClient(request =>
-        {
-            var response = new HttpResponseMessage(System.Net.HttpStatusCode.OK)
-            {
-                Content = new StringContent("""{"status":"ok"}""", Encoding.UTF8, "application/json")
-            };
-            response.Headers.Add("X-OpenClaw-Version", "2026.07.09");
-            return response;
-        }, requiredVersion: "2026.07.09");
-
-        var info = await client.GetGatewayInfoAsync();
-
-        Assert.True(info.Reachable);
-        Assert.Equal("matched", info.VersionStatus);
-        Assert.True(info.VersionMatches);
-        Assert.Null(info.Warning);
-    }
-
-    [Fact]
-    public async Task GetAgentsAsync_MapsRuntimeStatesFromGatewayStatus()
-    {
-        var staleTimestamp = DateTimeOffset.UtcNow.AddMinutes(-40).ToString("o");
-        var client = CreateClient(request =>
-        {
-            if (request.RequestUri?.AbsolutePath == "/tools/invoke")
-            {
-                using var doc = JsonDocument.Parse(request.Content!.ReadAsStringAsync().GetAwaiter().GetResult());
-                var agentId = doc.RootElement.GetProperty("args").GetProperty("sessionKey").GetString()!
-                    .Split(':', StringSplitOptions.RemoveEmptyEntries)[1];
-
-                object status = agentId switch
-                {
-                    "iris" => new { status = "active", isActive = true, currentTask = "Coordinate launch", model = "openai/gpt-5.5" },
-                    "programmer" => new { status = "idle", lastActivity = staleTimestamp, model = "openai/gpt-5.4" },
-                    "reviewer" => new { status = "failed", error = "gateway timeout", model = "openai/gpt-5.5" },
-                    "architekt" => new { status = "unsupported", message = "tool not available", model = "openai/gpt-5.5" },
-                    _ => new { status = "ready", model = "openai/gpt-5.5" }
-                };
-
-                return ToolResult(status);
-            }
-
-            return new HttpResponseMessage(System.Net.HttpStatusCode.NotFound);
-        }, agentIds: ["iris", "programmer", "reviewer", "architekt"]);
-
-        var agents = await client.GetAgentsAsync();
-
-        Assert.Collection(agents.OrderBy(a => a.Id),
-            architekt =>
-            {
-                Assert.Equal("architekt", architekt.Id);
-                Assert.Equal("unsupported", architekt.StatusKind);
-                Assert.Equal("Unsupported", architekt.StatusLabel);
-                Assert.Equal("tool not available", architekt.StatusDetail);
-            },
-            iris =>
-            {
-                Assert.Equal("iris", iris.Id);
-                Assert.Equal("connected", iris.StatusKind);
-                Assert.Equal("Arbeitet", iris.StatusLabel);
-            },
-            programmer =>
-            {
-                Assert.Equal("programmer", programmer.Id);
-                Assert.Equal("stale", programmer.StatusKind);
-                Assert.Equal("Stale", programmer.StatusLabel);
-                Assert.NotNull(programmer.StatusDetail);
-                Assert.Contains("40m", programmer.StatusDetail!);
-            },
-            reviewer =>
-            {
-                Assert.Equal("reviewer", reviewer.Id);
-                Assert.Equal("error", reviewer.StatusKind);
-                Assert.Equal("Fehler", reviewer.StatusLabel);
-                Assert.Equal("gateway timeout", reviewer.StatusDetail);
-            });
-    }
-
-    [Fact]
-    public async Task AgentConfigService_RejectsNullBytesBeforeReplacingFile()
-    {
-        var agentId = $"phase-p4-{Guid.NewGuid():N}";
-        var workspacePath = Path.Combine("/mnt", $"workspace-{agentId}");
-        Directory.CreateDirectory(workspacePath);
-        var configPath = Path.Combine(workspacePath, "TOOLS.md");
-        await File.WriteAllTextAsync(configPath, "original");
-
-        try
-        {
-            var service = new AgentConfigService();
-            var attempt = await service.SaveConfigFileAsync(agentId, "TOOLS.md", "bad\0content");
-
-            Assert.NotNull(attempt.Failure);
-            Assert.Equal("validation_failed", attempt.Failure!.Code);
-            Assert.Equal("failed", attempt.Failure.Validation.Status);
-            Assert.Contains(attempt.Failure.Validation.Errors, error => error.Contains("null bytes", StringComparison.OrdinalIgnoreCase));
-            Assert.Equal("original", await File.ReadAllTextAsync(configPath));
-        }
-        finally
-        {
-            Directory.Delete(workspacePath, recursive: true);
-        }
-    }
-
-    [Fact]
-    public async Task AgentConfigService_ReturnsBackupAndReloadShape_OnSuccessfulSave()
-    {
-        var agentId = $"phase-p4-{Guid.NewGuid():N}";
-        var workspacePath = Path.Combine("/mnt", $"workspace-{agentId}");
-        Directory.CreateDirectory(workspacePath);
-        var configPath = Path.Combine(workspacePath, "TOOLS.md");
-        await File.WriteAllTextAsync(configPath, "before");
-
-        try
-        {
-            var service = new AgentConfigService();
-            var attempt = await service.SaveConfigFileAsync(agentId, "TOOLS.md", "after");
-
-            Assert.NotNull(attempt.SaveResult);
-            var result = attempt.SaveResult!;
-            Assert.Equal("passed", result.Validation.Status);
-            Assert.Equal("markdown", result.Validation.FileKind);
-            Assert.Equal("created", result.Backup.Status);
-            Assert.True(result.Backup.BackupCreated);
-            Assert.Equal("not_supported", result.ReloadCheck.Status);
-            Assert.False(string.IsNullOrWhiteSpace(result.ReloadCheck.Message));
-            Assert.Equal("before", await File.ReadAllTextAsync(configPath + ".bak"));
-            Assert.Equal("after", await File.ReadAllTextAsync(configPath));
-        }
-        finally
-        {
-            Directory.Delete(workspacePath, recursive: true);
-        }
-    }
-
     [Fact]
     public async Task AgentConfigSave_AuditsFailureWithoutLeakingContent()
     {
-        var configService = new FakeAgentConfigService(new AgentConfigSaveAttempt(
-            null,
-            new AgentConfigSaveFailure(
-                "validation_failed",
-                new AgentConfigValidationResult("failed", "markdown", ["Content contains null bytes."]),
-                new AgentConfigBackupResult("not_applicable", false),
-                new AgentConfigReloadCheckResult("not_supported", "No hot reload available."))));
+        var configService = new RejectingOpenClawAgentConfigurationService();
         var activityRepo = new CapturingActivityRepository();
 
         var controller = new AgentsController(
@@ -365,8 +182,13 @@ public sealed class MissionControlPhaseTests
                 }
             }
         };
+        controller.Request.Headers["Idempotency-Key"] = "test-config-save";
 
-        var result = await controller.SaveConfigFile("programmer", "TOOLS.md", new SaveConfigRequest("secret\0payload"), CancellationToken.None);
+        var result = await controller.SaveConfigFile(
+            "programmer",
+            "TOOLS.md",
+            new SaveConfigRequest("secret\0payload", "expected-hash"),
+            CancellationToken.None);
 
         var statusResult = Assert.IsAssignableFrom<IStatusCodeHttpResult>(result);
         Assert.Equal(StatusCodes.Status400BadRequest, statusResult.StatusCode);
@@ -377,66 +199,60 @@ public sealed class MissionControlPhaseTests
         Assert.DoesNotContain("payload", audit.Message, StringComparison.OrdinalIgnoreCase);
     }
 
-    private static OpenClawGatewayClient CreateClient(
-        Func<HttpRequestMessage, HttpResponseMessage> responder,
-        string? requiredVersion = null,
-        string[]? agentIds = null)
-    {
-        var configValues = new Dictionary<string, string?>
-        {
-            ["Integrations:OpenClaw:RequiredVersion"] = requiredVersion
-        };
-
-        if (agentIds is not null)
-        {
-            var configPath = Path.GetTempFileName();
-            File.WriteAllText(configPath, JsonSerializer.Serialize(new
-            {
-                agents = new
-                {
-                    list = agentIds.Select(id => new { id }).ToArray()
-                }
-            }));
-            configValues["AgentConfigPath"] = configPath;
-        }
-
-        var configuration = new ConfigurationBuilder()
-            .AddInMemoryCollection(configValues)
-            .Build();
-
-        var httpClient = new HttpClient(new StubHttpMessageHandler(responder))
-        {
-            BaseAddress = new Uri("http://gateway.local")
-        };
-
-        return new OpenClawGatewayClient(httpClient, configuration);
-    }
-
-    private static HttpResponseMessage ToolResult(object payload)
-        => new(System.Net.HttpStatusCode.OK)
-        {
-            Content = new StringContent(
-                JsonSerializer.Serialize(new { ok = true, result = payload }),
-                Encoding.UTF8,
-                "application/json")
-        };
 }
 
-file sealed class StubHttpMessageHandler(Func<HttpRequestMessage, HttpResponseMessage> responder) : HttpMessageHandler
+file sealed class RejectingOpenClawAgentConfigurationService
+    : IOpenClawAgentConfigurationService
 {
-    protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
-        => Task.FromResult(responder(request));
-}
+    public Task<OpenClawAgentFileCollectionDto> GetAgentFilesAsync(
+        string agentId,
+        CancellationToken cancellationToken = default)
+        => throw new NotSupportedException();
 
-file sealed class FakeAgentConfigService(AgentConfigSaveAttempt attempt) : IAgentConfigService
-{
-    public IReadOnlyList<AgentConfigFileInfo> GetConfigFiles(string agentId) => [];
+    public Task<OpenClawAgentFileDto> GetAgentFileAsync(
+        string agentId,
+        string fileName,
+        CancellationToken cancellationToken = default)
+        => throw new NotSupportedException();
 
-    public Task<AgentConfigFileContent?> GetConfigFileAsync(string agentId, string fileName, CancellationToken ct = default)
-        => Task.FromResult<AgentConfigFileContent?>(null);
+    public Task<OpenClawAgentFileWriteDto> SetAgentFileAsync(
+        string agentId,
+        string fileName,
+        UpdateOpenClawAgentFileRequest request,
+        OpenClawInvocationContext invocationContext,
+        CancellationToken cancellationToken = default)
+        => throw new OpenClawAgentConfigurationValidationException(
+            "content",
+            "Content contains null bytes.");
 
-    public Task<AgentConfigSaveAttempt> SaveConfigFileAsync(string agentId, string fileName, string content, CancellationToken ct = default)
-        => Task.FromResult(attempt);
+    public Task<OpenClawWorkspaceCollectionDto> GetWorkspaceAsync(
+        string agentId,
+        string? path,
+        int offset,
+        int limit,
+        CancellationToken cancellationToken = default)
+        => throw new NotSupportedException();
+
+    public Task<OpenClawWorkspaceFileDto> GetWorkspaceFileAsync(
+        string agentId,
+        string path,
+        CancellationToken cancellationToken = default)
+        => throw new NotSupportedException();
+
+    public Task<OpenClawConfigSchemaLookupDto> GetConfigSchemaAsync(
+        string path,
+        CancellationToken cancellationToken = default)
+        => throw new NotSupportedException();
+
+    public Task<OpenClawConfigSnapshotDto> GetConfigAsync(
+        CancellationToken cancellationToken = default)
+        => throw new NotSupportedException();
+
+    public Task<OpenClawConfigPatchDto> PatchConfigAsync(
+        PatchOpenClawConfigRequest request,
+        OpenClawInvocationContext invocationContext,
+        CancellationToken cancellationToken = default)
+        => throw new NotSupportedException();
 }
 
 file sealed class CapturingActivityRepository : IActivityRepository
@@ -467,7 +283,9 @@ file sealed class FakeAgentService : IAgentService
         => Task.FromResult<IReadOnlySet<string>>(new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "iris", "bao", "programmer" });
 }
 
-file sealed class FakeAgentRuntime : Nexus.Api.Integrations.IAgentRuntime
+file sealed class FakeAgentRuntime :
+    Nexus.Api.Integrations.IAgentRuntime,
+    IOpenClawChatService
 {
     public string Name => "fake";
 
@@ -476,6 +294,14 @@ file sealed class FakeAgentRuntime : Nexus.Api.Integrations.IAgentRuntime
 
     public Task<Nexus.Api.Integrations.AgentChatResult> ChatAsync(string message, string conversationId, string agentId, CancellationToken cancellationToken)
         => Task.FromResult(new Nexus.Api.Integrations.AgentChatResult("fake", agentId, conversationId, "ok"));
+
+    public Task<Nexus.Api.Integrations.AgentChatResult> SendAsync(
+        string message,
+        string conversationId,
+        string agentId,
+        OpenClawInvocationMetadata invocation,
+        CancellationToken cancellationToken = default)
+        => ChatAsync(message, conversationId, agentId, cancellationToken);
 }
 
 file sealed class FakeDashboardService : IDashboardService
@@ -492,5 +318,6 @@ file sealed class FakeDashboardService : IDashboardService
     public Task<AgentModelInfo?> GetAgentModelAsync(string agentId) => Task.FromResult<AgentModelInfo?>(null);
     public Task<bool> SetAgentModelAsync(string agentId, string model) => Task.FromResult(false);
     public Task<List<AgentActivityEntry>> GetAgentActivityAsync(string agentId, int limit) => Task.FromResult(new List<AgentActivityEntry>());
-    public List<ModelOption> GetAvailableModels() => [];
+    public Task<List<ModelOption>> GetAvailableModelsAsync(CancellationToken ct)
+        => Task.FromResult(new List<ModelOption>());
 }