fix(scan): repair pre-existing tsc errors so the build is green
The scan feature had 16 tsc errors from refactor drift; npm run build failed. - modals/hooks/* are five levels deep but imported ../../../../lib (four); corrected to ../../../../../lib. - useScanDiagnosticsModalModel / useScanReviewQueueModalModel picked saveReviewSample / canSaveReviewSample / loadReviewQueue from the modal Props, but the components wire those through from controller.*; source them from the controller type instead (fixes the downstream unknown-type errors). - useScanResultCardModel let its field-row tuple array widen to (string | ParsedField)[][]; annotate it Array<[string, ParsedField]> like the sibling hook. - ScanTopControlsModel was missing autoScanRunning (destructured by the component); add it. useScanTopControlsModel does not use refreshCaptureSources, so its input is Omit<...,"refreshCaptureSources">. tsc, vite build, and the electron build all pass; 74 tests green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
import { detailFingerprint } from "../../../../lib/autoScanLoop";
|
||||
import { sourceVersion } from "../../../../lib/genshinData";
|
||||
import { detailFingerprint } from "../../../../../lib/autoScanLoop";
|
||||
import { sourceVersion } from "../../../../../lib/genshinData";
|
||||
import { useCallback, useMemo, type MouseEvent } from "react";
|
||||
import type { ScanDiagnosticsModalProps } from "../types";
|
||||
|
||||
@@ -39,16 +39,20 @@ export interface ScanDiagnosticsModalModel {
|
||||
canSaveReviewSample: boolean;
|
||||
}
|
||||
|
||||
type ScanDiagnosticsController = ScanDiagnosticsModalProps["controller"];
|
||||
|
||||
interface UseScanDiagnosticsModalModelInput extends Pick<
|
||||
ScanDiagnosticsModalProps,
|
||||
| "setDetailsOpen"
|
||||
| "setDiagnosticsOpen"
|
||||
| "saveReviewSample"
|
||||
| "canSaveReviewSample"
|
||||
| "latestCapture"
|
||||
| "controller"
|
||||
> {
|
||||
captureStatus: string;
|
||||
// saveReviewSample / canSaveReviewSample live on the controller, not the modal
|
||||
// props; the component wires them through from controller.* .
|
||||
saveReviewSample: ScanDiagnosticsController["saveReviewSample"];
|
||||
canSaveReviewSample: ScanDiagnosticsController["canSaveReviewSample"];
|
||||
}
|
||||
|
||||
export function useScanDiagnosticsModalModel({
|
||||
|
||||
Reference in New Issue
Block a user